Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run examples on commit #412

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Run examples on commit #412

merged 2 commits into from
Oct 12, 2023

Conversation

billschereriii
Copy link
Contributor

Fix bug with running examples introduced in multiDB PR.
Move test of static builds and examples to on-commit, not post-merge

@billschereriii billschereriii added area: test Issues related to the test suite area: CI/CD Issues related to continuous integration and deployment labels Oct 12, 2023
@billschereriii billschereriii self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #412 (366a340) into develop (362f576) will decrease coverage by 0.68%.
The diff coverage is n/a.

❗ Current head 366a340 differs from pull request most recent head 78f9a3b. Consider uploading reports for the commit 78f9a3b to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #412      +/-   ##
===========================================
- Coverage    79.05%   78.37%   -0.68%     
===========================================
  Files           97       97              
  Lines         7079     7348     +269     
===========================================
+ Hits          5596     5759     +163     
- Misses        1483     1589     +106

see 40 files with indirect coverage changes

ashao
ashao approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing up those tests!

@billschereriii billschereriii merged commit df7bdf0 into CrayLabs:develop Oct 12, 2023
44 checks passed
@billschereriii billschereriii deleted the touchup branch October 12, 2023 17:05
ashao pushed a commit that referenced this pull request Oct 17, 2023
@billschereriii @ashao
Run examples on commit (#412)
3551b15 
Run examples on commit to keep them fresh
[ committed by @billschereriii ]
[ reviewed by @ashao ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashao ashao ashao approved these changes

Assignees

@billschereriii billschereriii

Labels
area: CI/CD Issues related to continuous integration and deployment area: test Issues related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billschereriii @ashao